<html>
<head><meta charset="utf-8"><title>ena#19 values_since_snapshot · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ena.2319.20values_since_snapshot.html">ena#19 values_since_snapshot</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="161154839"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ena%2319%20values_since_snapshot/near/161154839" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ena.2319.20values_since_snapshot.html#161154839">(Mar 19 2019 at 14:26)</a>:</h4>
<p><span class="user-mention" data-user-id="121053">@varkor</span> -- I <a href="https://github.com/rust-lang-nursery/ena/pull/19#pullrequestreview-216185760" target="_blank" title="https://github.com/rust-lang-nursery/ena/pull/19#pullrequestreview-216185760">left a review on ena#19</a> -- just had a minor nit. Do you think you'd be able to add some docs? I can certainly publish a new version, as well.</p>



<a name="161154984"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ena%2319%20values_since_snapshot/near/161154984" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ena.2319.20values_since_snapshot.html#161154984">(Mar 19 2019 at 14:28)</a>:</h4>
<p>actually, I think I misunderstood</p>



<a name="161154993"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ena%2319%20values_since_snapshot/near/161154993" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ena.2319.20values_since_snapshot.html#161154993">(Mar 19 2019 at 14:28)</a>:</h4>
<p>never mind, I'll just land as is</p>



<a name="161155365"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ena%2319%20values_since_snapshot/near/161155365" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ena.2319.20values_since_snapshot.html#161155365">(Mar 19 2019 at 14:32)</a>:</h4>
<p>I guess I'll release this as 0.12.0 since it is technically a breaking change</p>



<a name="161155694"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ena%2319%20values_since_snapshot/near/161155694" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ena.2319.20values_since_snapshot.html#161155694">(Mar 19 2019 at 14:35)</a>:</h4>
<p>see <a href="https://github.com/rust-lang-nursery/ena/pull/20" target="_blank" title="https://github.com/rust-lang-nursery/ena/pull/20">https://github.com/rust-lang-nursery/ena/pull/20</a> -- published</p>



<a name="161161203"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ena%2319%20values_since_snapshot/near/161161203" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> varkor <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ena.2319.20values_since_snapshot.html#161161203">(Mar 19 2019 at 15:35)</a>:</h4>
<p>thanks!</p>



<a name="161200193"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ena%2319%20values_since_snapshot/near/161200193" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> varkor <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ena.2319.20values_since_snapshot.html#161200193">(Mar 19 2019 at 23:20)</a>:</h4>
<p>I've committed a faux pas... I assumed this change was sufficient for rustc without actually patching it in locally</p>



<a name="161200272"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ena%2319%20values_since_snapshot/near/161200272" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> varkor <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ena.2319.20values_since_snapshot.html#161200272">(Mar 19 2019 at 23:20)</a>:</h4>
<p>it turns out that we need the method to be more public, and also to add the method to <code>SnapshotVec</code> to account for the type variable data structures</p>



<a name="161200296"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ena%2319%20values_since_snapshot/near/161200296" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> varkor <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ena.2319.20values_since_snapshot.html#161200296">(Mar 19 2019 at 23:21)</a>:</h4>
<p>I'm about to submit another PR; sorry for the unnecessary version</p>



<a name="161231475"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ena%2319%20values_since_snapshot/near/161231475" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> varkor <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ena.2319.20values_since_snapshot.html#161231475">(Mar 20 2019 at 10:10)</a>:</h4>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span>: I've submitted <a href="https://github.com/rust-lang-nursery/ena/pull/21" target="_blank" title="https://github.com/rust-lang-nursery/ena/pull/21">https://github.com/rust-lang-nursery/ena/pull/21</a> – sorry for the trouble</p>



<a name="161243111"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ena%2319%20values_since_snapshot/near/161243111" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ena.2319.20values_since_snapshot.html#161243111">(Mar 20 2019 at 12:48)</a>:</h4>
<p><span class="user-mention" data-user-id="121053">@varkor</span> np :)</p>



<a name="161484998"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ena%2319%20values_since_snapshot/near/161484998" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ena.2319.20values_since_snapshot.html#161484998">(Mar 22 2019 at 21:19)</a>:</h4>
<p><span class="user-mention" data-user-id="121053">@varkor</span> ok, sorry, just reviewed that PR</p>



<a name="161485093"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ena%2319%20values_since_snapshot/near/161485093" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ena.2319.20values_since_snapshot.html#161485093">(Mar 22 2019 at 21:20)</a>:</h4>
<p>Merged. Can you maybe open a PR bumping the cargo.toml version number and updating RELEASES.md? I guess it might as well be a new major version again</p>



<a name="161504155"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ena%2319%20values_since_snapshot/near/161504155" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Charles Lew <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ena.2319.20values_since_snapshot.html#161504155">(Mar 23 2019 at 03:23)</a>:</h4>
<p>I've opened a PR to bump the version to 0.13.0: <a href="https://github.com/rust-lang-nursery/ena/pull/22" target="_blank" title="https://github.com/rust-lang-nursery/ena/pull/22">https://github.com/rust-lang-nursery/ena/pull/22</a></p>
<p>It seems ena doesn't have a RELEASES.md (like rustc do)...</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>